----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34945/#review86221 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py <https://reviews.apache.org/r/34945/#comment138140> A couple issues with this: 1) If someone changes the default(...,None) to default(...,"") in the future, then this check will fail to remove the config 2) This only removes the config from the dictionary if it exists. If we're deleting the entry, should we even have parameters for it? Shouldn't we also remove default_topology_max_replication_wait_time_sec and default_topology_min_replication_count - Jonathan Hurley On June 2, 2015, 10:50 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34945/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 10:50 a.m.) > > > Review request for Ambari, Jonathan Hurley, Sumit Mohanty, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-11611 > https://issues.apache.org/jira/browse/AMBARI-11611 > > > Repository: ambari > > > Description > ------- > > Now Ambari always use 1 as the value. This will render Storm-HA to not work > out of the box. We want to find the formula. > So these 2 entries should be deleted. > topology.max.replication.wait.time.sec.default : 60 > topology.min.replication.count.default : 1 > > Fix failing unit test > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > 6c3078b > > Diff: https://reviews.apache.org/r/34945/diff/ > > > Testing > ------- > > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 136 licence. > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [1.718s] > [INFO] Ambari Metrics Common ............................. SUCCESS [0.748s] > [INFO] Ambari Server ..................................... SUCCESS [49.324s] > [INFO] Ambari Agent ...................................... SUCCESS [18.685s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:11.292s > [INFO] Finished at: Tue Jun 02 17:49:39 EEST 2015 > [INFO] Final Memory: 48M/482M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
