----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35085/#review86743 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On June 4, 2015, 3:50 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35085/ > ----------------------------------------------------------- > > (Updated June 4, 2015, 3:50 p.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-11699 > https://issues.apache.org/jira/browse/AMBARI-11699 > > > Repository: ambari > > > Description > ------- > > - Deploy cluster with HBASE, 3 nodes > - Stop and delete Region Server from one of the 3 hosts. > - Alert shows wrong data even after 10 minutes. > > The root cause of this is that the aggregate alerts only recalculate on a > state change. We need to explicitly force the recalculation. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/events/AggregateAlertRecalculateEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java > 99542ef > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceComponentHostListener.java > 92008e3 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java > ef0430e > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java > c63c0d4 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java > 6bf808d > > ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java > e37f0cb > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java > 67c08ba > > Diff: https://reviews.apache.org/r/35085/diff/ > > > Testing > ------- > > mvn clean test > > Also, removed a host which had alerts which were aggregated and saw the > aggregate alert recalculate. > > > Thanks, > > Jonathan Hurley > >
