----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35167/#review86886 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java <https://reviews.apache.org/r/35167/#comment139032> See pattern from ServiceComponentHostImpl.persist(); there's no need to lock on the cluster unless there is work to do. This actually can cause a deadlock when persisting already persisted entries. ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java <https://reviews.apache.org/r/35167/#comment139026> if the local unlock() fails, then the cluster lock will never get unlocked. ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java <https://reviews.apache.org/r/35167/#comment139031> If the unlock() fails, then the cluster unlock() will never get called ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java <https://reviews.apache.org/r/35167/#comment139029> The cluster global lock is not necessary here since no cluster data is being read. - Jonathan Hurley On June 5, 2015, 8:28 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35167/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 8:28 p.m.) > > > Review request for Ambari, Jonathan Hurley, Mahadev Konar, Myroslav > Papirkovskyy, and Yusaku Sako. > > > Bugs: AMBARI-11744 > https://issues.apache.org/jira/browse/AMBARI-11744 > > > Repository: ambari > > > Description > ------- > > This was observed while adding Ganglia to an existing cluster via Add > Services Wizard. > It hung after clicking Deploy at task 2 / 6. > Browser tools showed that it was doing a PUT and this call timed out after 3 > mins. > All subsequent API calls hung. Ambari Server was not responsive at all to any > API calls after that. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java > 3fcb84b > > ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java > 9ec0370 > > Diff: https://reviews.apache.org/r/35167/diff/ > > > Testing > ------- > > Verified manually. > > > Thanks, > > Sid Wagle > >
