----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35168/#review86900 -----------------------------------------------------------
Ship it! Andrew pointed out some good finds; aside from the `wait_til` being duplicate code that we might not need, it looks good. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py <https://reviews.apache.org/r/35168/#comment139061> There's a convention that we use in some places, instead of the Execute(...) that has a retry timeout: `@retry(times=24, sleep_time=5, err_class=Fail)` - Jonathan Hurley On June 5, 2015, 8:55 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35168/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 8:55 p.m.) > > > Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and > Sid Wagle. > > > Bugs: AMBARI-11743 > https://issues.apache.org/jira/browse/AMBARI-11743 > > > Repository: ambari > > > Description > ------- > > 1. Install cluster with Ambari 2.1 and HDP 2.3 > 2. Add services HDFS, YARN, MR, ZK, and HBaste > 3. Perform several Stop All and Start All on HDFS service > 4. Periodically, HBase Master will crash > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py > de05da2 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py > d26d145 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py b920c17 > > Diff: https://reviews.apache.org/r/35168/diff/ > > > Testing > ------- > > Tested this on a live cluster. Several attempts at restarting NameNode worked > and Hbase master was still up. > Also tested it with NameNode HA. > > Still need to test Rolling Upgrade and run full set of unit tests. > > > Thanks, > > Alejandro Fernandez > >
