> On June 9, 2015, 3:09 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml,
> >  line 142
> > <https://reviews.apache.org/r/35251/diff/2/?file=981491#file981491line142>
> >
> >     Why is this being added in this patch?  Is this change related to the 
> > oozie_heapsize issue?
> 
> Andrew Onischuk wrote:
>     It is not related as well. This is a thing I just wanted to add because 
> of using some API calls I found out this missing since Yarn cannot be 
> installed w/o MAPRED and results in errors.

Thanks for the info.  I would recommend implementing this as a separate patch, 
since it is not related to the oozie_heapsize fix.


> On June 9, 2015, 3:09 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/5.0.0.2.3/configuration/oozie-env.xml,
> >  line 24
> > <https://reviews.apache.org/r/35251/diff/2/?file=981490#file981490line24>
> >
> >     Why is this being removed in this patch?  This looks like an un-related 
> > change.
> 
> Andrew Onischuk wrote:
>     This is unrelated change, that changes are duplicated beyond having 
> properties inhertance. This is just a refactoring I saw on my way doing the 
> changes.

Thanks for the info.  I would recommend implementing this as a separate patch, 
since it is not related to the oozie_heapsize fix.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35251/#review87188
-----------------------------------------------------------


On June 9, 2015, 3:21 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35251/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 3:21 p.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-11811
>     https://issues.apache.org/jira/browse/AMBARI-11811
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Oozie is thinking that heapsize is in kb and failing with too low
> heapsize.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  ca7b2b1 
>   
> ambari-server/src/main/resources/common-services/OOZIE/5.0.0.2.3/configuration/oozie-env.xml
>  fe80bf5 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 
> ca82d46 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  b049fd3 
> 
> Diff: https://reviews.apache.org/r/35251/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Reply via email to