> On June 9, 2015, 3:49 p.m., Nate Cole wrote: > > How is the build number enforced, or is that a different patch? Looks like > > this is just a string that someone (ui?) would use to see if it should be > > allowed.
Thanks for the review. There is no built in enforcement or validation of the build number. It's purely informational. For the current contrib views (Tez, Hive, etc...) we plan to have the build process inject the build number into the view.xml. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35254/#review87207 ----------------------------------------------------------- On June 9, 2015, 3:04 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35254/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 3:04 p.m.) > > > Review request for Ambari, Nate Cole and Robert Levas. > > > Bugs: AMBARI-11814 > https://issues.apache.org/jira/browse/AMBARI-11814 > > > Repository: ambari > > > Description > ------- > > The view.xml xsd should allow view.xml to optionally contain <build> for the > view build number. > The build number should also be exposed through the REST API when > introspecting a view or view instance. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewVersionResourceProvider.java > 6352817 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java > 6039fb6 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java > e32e3aa > > ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java > f9b898d > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 0484cfc > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ac32eb6 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 28a6f1a > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > d2f17c1 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1d24d72 > > ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewEntityTest.java > ac2715c > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java > c4d4876 > > ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java > 2391ad6 > ambari-views/examples/phone-list-view/src/main/resources/view.xml bd927ca > ambari-views/src/main/java/org/apache/ambari/view/ViewDefinition.java > f378dde > ambari-views/src/main/resources/view.xsd 46adf27 > > Diff: https://reviews.apache.org/r/35254/diff/ > > > Testing > ------- > > Manual tested. > > New unit tests added. > > mvn clean test > > all tests pass > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 45:56 min > [INFO] Finished at: 2015-06-09T10:57:40-04:00 > [INFO] Final Memory: 54M/1519M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
