-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35283/
-----------------------------------------------------------

Review request for Ambari, Srimanth Gunturi and Yusaku Sako.


Bugs: AMBARI-11821
    https://issues.apache.org/jira/browse/AMBARI-11821


Repository: ambari


Description
-------

Behavior of service component endpoint for metric related fields inside 
ServiceComponent map was undefined in HA state of the service component. It 
randoml picked the host component and rolled up the metric values instead of 
picking up the active master host component. This mostly affected HBase service 
as web ui was using those serviceComponent field.

As part of this patch, ambari-web now no longer looks at any serviceComponent 
fields for any service. Instead web code figures out the active host component 
and gets the metric values from the host component.


Diffs
-----

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/YARN_metrics.json
 92c32d8 
  ambari-web/app/assets/data/metrics/HBASE/definition.json 3374f2d 
  ambari-web/app/controllers/global/update_controller.js af7b69e 
  ambari-web/app/mappers/service_metrics_mapper.js 9c39fc6 
  ambari-web/app/messages.js 88c716d 
  ambari-web/app/models/service/hbase.js 662577f 
  ambari-web/app/models/service/mapreduce2.js 388b236 
  ambari-web/app/models/service/yarn.js eb33886 
  ambari-web/app/styles/enhanced_service_dashboard.less 0ff9c88 
  ambari-web/test/controllers/global/update_controller_test.js f55136b 
  ambari-web/test/mappers/service_mapper_test.js 1ab4cf9 

Diff: https://reviews.apache.org/r/35283/diff/


Testing
-------

tested the cluster dashboard and service summary pages with the patch on a live 
cluster with and without HA enabled for NameNode, ResourceManager and Hbase 
master.

verified that all existing unit tests passess with the patch


Thanks,

Jaimin Jetly

Reply via email to