----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35366/#review87597 -----------------------------------------------------------
Ship it! Ship It! - Robert Levas On June 11, 2015, 2:10 p.m., Erik Bergenholtz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35366/ > ----------------------------------------------------------- > > (Updated June 11, 2015, 2:10 p.m.) > > > Review request for Ambari, Robert Levas and Tom Beerbower. > > > Bugs: AMBARI-11864 > https://issues.apache.org/jira/browse/AMBARI-11864 > > > Repository: ambari > > > Description > ------- > > This patch adds the ability to kill query from query page (same button as in > history page), ensures Safari 8 renders properly and corrects the desribe > formatted queries > > > Diffs > ----- > > contrib/views/hive/pom.xml 9638e96 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParser.java > 7482921 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/rm/RMParserFactory.java > 596d1d1 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/Job.java > 44a338c > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobImpl.java > ac1c3da > contrib/views/hive/src/main/resources/ui/hive-web/Brocfile.js 8a367c9 > > contrib/views/hive/src/main/resources/ui/hive-web/app/adapters/application.js > 5e7a05b > > contrib/views/hive/src/main/resources/ui/hive-web/app/components/job-tr-view.js > PRE-CREATION > > contrib/views/hive/src/main/resources/ui/hive-web/app/components/modal-widget.js > 5172664 > > contrib/views/hive/src/main/resources/ui/hive-web/app/components/navbar-widget.js > PRE-CREATION > > contrib/views/hive/src/main/resources/ui/hive-web/app/components/notify-widget.js > 25ae1b3 > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/application.js > PRE-CREATION > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/columns.js > 38d1b95 > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/databases.js > 742657c > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/file-resources.js > 578fa67 > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/history.js > c19b131 > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js > a31e984 > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index/history-query/explain.js > 2f3e78d > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index/history-query/logs.js > 3c710d3 > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/insert-udfs.js > fcfd113 > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/job-progress.js > c80ae81 > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/job.js > 2d53524 > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/loaded-files.js > 3a11171 > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/messages.js > db8e0b5 > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/open-queries.js > 722ea0a > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/query-tabs.js > 4c50c2e > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/settings.js > 074d3d1 > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/tables.js > 1d773e7 > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/tez-ui.js > 6ce7147 > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/udf.js > 3f8d3ed > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/udfs.js > d9a7d6b > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visual-explain.js > 9501301 > contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js > 09d57b5 > > contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/notify.js > cf9d64a > contrib/views/hive/src/main/resources/ui/hive-web/app/routes/application.js > 245937a > contrib/views/hive/src/main/resources/ui/hive-web/app/routes/history.js > 5363f7e > contrib/views/hive/src/main/resources/ui/hive-web/app/routes/queries.js > 6ed55b5 > contrib/views/hive/src/main/resources/ui/hive-web/app/routes/udfs.js > 9093197 > contrib/views/hive/src/main/resources/ui/hive-web/app/services/database.js > PRE-CREATION > contrib/views/hive/src/main/resources/ui/hive-web/app/services/file.js > PRE-CREATION > contrib/views/hive/src/main/resources/ui/hive-web/app/services/job.js > PRE-CREATION > contrib/views/hive/src/main/resources/ui/hive-web/app/services/notify.js > 38e88c3 > contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss > 3ae64ec > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/application.hbs > 2242a4f > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/_typeahead-widget.hbs > 4083ad6 > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/job-tr-view.hbs > PRE-CREATION > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/navbar-widget.hbs > PRE-CREATION > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/typeahead-widget.hbs > 4083ad6 > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/databases-tree.hbs > bdac484 > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/databases.hbs > 392b8f3 > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/history.hbs > d98fbcd > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/index.hbs > b6f27aa > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/insert-udfs.hbs > 0911835 > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/navbar.hbs > f8f6bcb > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/queries.hbs > 692a462 > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/query-tabs.hbs > c170e02 > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/udfs.hbs > 5bb8759 > contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js > d63c5ce > contrib/views/hive/src/main/resources/ui/hive-web/app/utils/functions.js > f7756fc > contrib/views/hive/src/main/resources/ui/hive-web/app/views/history.js > 8a914f0 > contrib/views/hive/src/main/resources/ui/hive-web/app/views/insert-udfs.js > 70ed640 > contrib/views/hive/src/main/resources/ui/hive-web/app/views/navbar.js > 0c535db > > contrib/views/hive/src/main/resources/ui/hive-web/app/views/visual-explain.js > 52d92b6 > contrib/views/hive/src/main/resources/ui/hive-web/bower.json 24e8821 > contrib/views/hive/src/main/resources/ui/hive-web/package.json 8b5f669 > contrib/views/hive/src/main/resources/ui/hive-web/testem.json 5a8d375 > contrib/views/hive/src/main/resources/ui/hive-web/tests/helpers/api-mock.js > 39487fa > > contrib/views/hive/src/main/resources/ui/hive-web/tests/helpers/start-app.js > e029055 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/integration/database-test.js > 604da58 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/integration/query-editor-test.js > 19c2356 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/integration/tez-ui-test.js > PRE-CREATION > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/adapters/application.js > 09e3c1b > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/collapsible-widget-test.js > 2f25bab > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/column-filter-widget-test.js > 2afe669 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/date-range-widget-test.js > 13a3e89 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/expander-widget-test.js > 2b34af5 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/extended-input-test.js > 7a3fcbf > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/job-tr-view-test.js > PRE-CREATION > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/modal-widget-test.js > PRE-CREATION > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/no-bubbling-test.js > 2d158ae > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/number-range-widget-test.js > 92d892e > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/popover-widget-test.js > b75148d > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/progress-widget-test.js > 4e081bd > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/query-editor-test.js > 0b993d4 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/select-widget-test.js > b1175f2 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/tabs-wiget-test.js > 8eaddbe > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/typeahead-widget-test.js > e36499e > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/columns.js > f99a5e4 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/databases-test.js > 6bcc733 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/history-test.js > 51d4112 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/index-test.js > 98fdf87 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/insert-udfs-test.js > 84803d4 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/job-test.js > 1c76352 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/messages-test.js > PRE-CREATION > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/open-queries-test.js > b1c581a > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/settings-test.js > 8d2adbd > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/tables.js > 5e0f4b9 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/tez-ui-test.js > e04abd5 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/udf-test.js > c7ba9e4 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/udfs-test.js > 4160585 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/visual-explain-test.js > 622b615 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/services/notify-test.js > 45b8936 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/views/visual-explain-test.js > 97faea6 > contrib/views/hive/src/main/resources/view.xml 8e1b4c5 > contrib/views/pig/src/main/resources/ui/pig-web/vendor/emacs.js 23666f2 > > Diff: https://reviews.apache.org/r/35366/diff/ > > > Testing > ------- > > Unit Tests: > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.388 sec > Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.578 sec > Running org.apache.ambari.view.hive.resources.jobs.LogParserTest > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.067 sec > Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.147 sec > Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.219 sec > Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest > Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.204 sec > Running org.apache.ambari.view.hive.resources.files.FileServiceTest > Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.492 sec > Running > org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.13 sec > Running > org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest > Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.686 sec > Running > org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.598 sec > Running org.apache.ambari.view.hive.PropertyValidatorTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.105 sec > Results : > Tests run: 48, Failures: 0, Errors: 0, Skipped: 0 > INFO Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 306 licence. > > > Thanks, > > Erik Bergenholtz > >
