----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35368/#review87626 -----------------------------------------------------------
Ship it! awesome, thanks Bob! - John Speidel On June 11, 2015, 8:36 p.m., Robert Nettleton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35368/ > ----------------------------------------------------------- > > (Updated June 11, 2015, 8:36 p.m.) > > > Review request for Ambari, John Speidel, Robert Levas, and Sumit Mohanty. > > > Bugs: AMBARI-11866 > https://issues.apache.org/jira/browse/AMBARI-11866 > > > Repository: ambari > > > Description > ------- > > This patch resolves AMBARI-11866. > > The command retry logic needs to be enabled by default for Blueprints, due to > the new dynamic provisioning approach used in Ambari 2.1. > > This patch implements the following: > > 1. Adds a method to set the command retry settings in cluster-env to valid > defaults. By default, retry is enabled for INSTALL and START tasks, and the > timeout period is 600 seconds. This method will set these properties to the > expected defaults if the properties are not set in configuration. If the > properties have been set in either a Blueprint or Cluster Creation template, > then the user-specified values will overrider the defaults. > 2. Adds new unit tests to verify this change. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 4f747f2 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 9b1e786 > > Diff: https://reviews.apache.org/r/35368/diff/ > > > Testing > ------- > > 1. Ran the Blueprint unit tests in ambari-server, all passing. (I will run > the full ambari-server unit test suite prior to merging in both branches). > 2. Deployed a 3-node HDFS/Yarn cluster without the retry settings included in > the "cluster-env" configuration type. Verified that the cluster starts up > properly, and that the cluster configuration after deployment reflects that > these three properties are using the Blueprint-required defaults. > 3. Deployed a 3-node HDFS/Yarn cluster with custom retry settings, and > verified that these settings overrode the defaults specified in the > BlueprintConfigurationProcessor. > > > Thanks, > > Robert Nettleton > >
