----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35402/#review87756 -----------------------------------------------------------
Ship it! Ship It! - Robert Levas On June 12, 2015, 4:33 p.m., Robert Nettleton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35402/ > ----------------------------------------------------------- > > (Updated June 12, 2015, 4:33 p.m.) > > > Review request for Ambari, John Speidel, Mahadev Konar, and Robert Levas. > > > Bugs: AMBARI-11894 > https://issues.apache.org/jira/browse/AMBARI-11894 > > > Repository: ambari > > > Description > ------- > > This patch resolves AMBARI-11894. > > The Blueprint export process was incorrectly removing two Oozie heapsize > configuration properties from "oozie-env". > > A recent change, AMBARI-11811, registered these properties with the > configuration processor, in order to support the required updating of > heapsize properties. That change added these properties to a map that was > associated with hostname topology substitution, and so the > BlueprintConfigProcessor was removing these new properties, since they do not > contain hostname information. > > This patch fixes this problem by: > > 1. Creating a separate Map instance for "oozie-env" specifically for the > heapsize settings. Other "oozie-env" settings that require hostname > substitution are handled in the original map. > 2. Registered this new instance with the map for Memory-based property > updaters. This ensures that the property is still updated properly for > cluster creation (appending the "m"), but is no longer considered for > hostname exports, which is the correct behavior. > 3. Adds unit tests assertions to verify that these properties are not removed > during the Blueprint export process. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > af14529 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > fc6ec4b > > Diff: https://reviews.apache.org/r/35402/diff/ > > > Testing > ------- > > 1. Ran the Blueprint unit tests in ambari-server, all passing. I'll run the > full unit test suite prior to merging into both branches (trunk and > branch-2.1) > 2. Verified that the Blueprint export of a running cluster now includes these > properties with my patch applied. > > > Thanks, > > Robert Nettleton > >
