> On June 13, 2015, 1:10 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml, > > line 292 > > <https://reviews.apache.org/r/35401/diff/1/?file=983905#file983905line292> > > > > Description? > > Nate Cole wrote: > Any recommendations? I didn't know what to call this.
Yeah, I dont quite know either. We want the admins to understand what's going on here. Maybe something like, "Setting the entire stack to HDP-2.3.0.0-1234". > On June 13, 2015, 1:10 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml, > > line 334 > > <https://reviews.apache.org/r/35401/diff/1/?file=983906#file983906line334> > > > > Are empty tags required now? > > Nate Cole wrote: > They are required only if you don't want the same tasks to happen during > downgrade as upgrade. I added the tags in the places where we do a lot of > config changes for upgrade, but not on downgrade. I see, so their presence is basically a NOOP for downgrade. I'm worried someone might remove them thinking they don't do anything; should we document that's what they are there for? - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35401/#review87801 ----------------------------------------------------------- On June 12, 2015, 4:35 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35401/ > ----------------------------------------------------------- > > (Updated June 12, 2015, 4:35 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom > Beerbower. > > > Bugs: AMBARI-11891 > https://issues.apache.org/jira/browse/AMBARI-11891 > > > Repository: ambari > > > Description > ------- > > * Fix requires calling "hdp-select set all <version>", and "yum clean all" > * Changed upgrade packs to do this for each version > * Updated orchestration to use null service and component to mean "execute on > all hosts" > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > b5c998a > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > c0ae92a > ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py > e2a078c > ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml > 8c0a6d6 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 569a9ce > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml > 8734ce7 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > f4e847c > ambari-server/src/test/python/custom_actions/test_ru_execute_tasks.py > 062e420 > ambari-server/src/test/python/custom_actions/test_ru_set_all.py > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml > 61b74dd > > Diff: https://reviews.apache.org/r/35401/diff/ > > > Testing > ------- > > Python: > ---------------------------------------------------------------------- > Total run:758 > Total errors:0 > Total failures:0 > OK > > Java: > Tests run: 3078, Failures: 0, Errors: 0, Skipped: 28 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 29:51.536s > [INFO] Finished at: Fri Jun 12 16:20:17 EDT 2015 > [INFO] Final Memory: 30M/1368M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
