-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35523/#review88081
-----------------------------------------------------------



ambari-common/src/main/python/resource_management/core/shell.py (line 239)
<https://reviews.apache.org/r/35523/#comment140487>

    Can you add some explanation to the JIRA as to why the earlier fix did not 
work and tests that are done with this fix



ambari-common/src/main/python/resource_management/core/shell.py (line 367)
<https://reviews.apache.org/r/35523/#comment140486>

    Can we add some unit test for this change? This likely regressed in this 
release and as its an error scenario it will not get tested through other 
scenario based testing.


- Sumit Mohanty


On June 16, 2015, 3:55 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35523/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 3:55 p.m.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-11956
>     https://issues.apache.org/jira/browse/AMBARI-11956
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:  
> 1)Install Ambari and Enable HA (Hbase)  
> 2)Enable security (Mit)
> 
> Actual results:  
> Datanode stop failed
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/shell.py 75b5fcf 
> 
> Diff: https://reviews.apache.org/r/35523/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Reply via email to