----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35690/#review88657 -----------------------------------------------------------
Ship it! Looks good! ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java (line 66) <https://reviews.apache.org/r/35690/#comment141239> My guess is no. UPGRADING means RU was still in progress, so it's possible that ambari-server was restarted during the middle of RU, which we now support thanks to Nate. ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java (line 84) <https://reviews.apache.org/r/35690/#comment141240> What bootstrap do you mean? - Alejandro Fernandez On June 20, 2015, 3:58 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35690/ > ----------------------------------------------------------- > > (Updated June 20, 2015, 3:58 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-12042 > https://issues.apache.org/jira/browse/AMBARI-12042 > > > Repository: ambari > > > Description > ------- > > StackVersionListener is fragile by it's nature. > This jira focuses on mitigating any issues that may occur (recovery to a > valid state without direct edits to database) > If Ambari Server restarts and any version is still in INSTALLING state, it > should transition to INSTALL_FAILED so the user can retry. > > Also helps against accidental server restart during install repo version > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > e430c98 > > ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/35690/diff/ > > > Testing > ------- > > checked recovery and normal workflow on live cluster > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [2.938s] > [INFO] Ambari Metrics Common ............................. SUCCESS [1.519s] > [INFO] Ambari Server ..................................... SUCCESS > [45:12.130s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 45:22.579s > [INFO] Finished at: Sat Jun 20 17:21:05 EEST 2015 > [INFO] Final Memory: 37M/289M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
