-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35830/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-12125
https://issues.apache.org/jira/browse/AMBARI-12125
Repository: ambari
Description
-------
The bug here is in workflow:
server is upgraded
agents on hosts are upgraded. Linux systems allow overwriting files in use
(e.g. running binaries)
agent on all hosts but one are restarted
server is restarted
agent, that was not upgraded, registers on server. During registration, it
provides version that appears at /var/lib/ambari-agent/data/version file. But
agent version file is already upgraded! So old agent executable reads new
version file, and successfully registers on server.
That is an actual bug.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/Controller.py 572768a
ambari-agent/src/main/python/ambari_agent/Register.py 21aa8ec
ambari-agent/src/test/python/ambari_agent/TestController.py 4559331
ambari-agent/src/test/python/ambari_agent/TestRegistration.py d2c75ed
Diff: https://reviews.apache.org/r/35830/diff/
Testing
-------
The same test is failing also on trunk
======================================================================
FAIL: test_attribute_environment_non_root
(TestExecuteResource.TestExecuteResource)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/media/plextor/ambari/ambari-common/src/test/python/mock/mock.py", line
1199, in patched
return func(*args, **keywargs)
File
"/media/plextor/ambari/ambari-agent/src/test/python/resource_management/TestExecuteResource.py",
line 196, in test_attribute_environment_non_root
self.assertEqual(popen_mock.call_args_list[0][0][0], expected_command)
AssertionError: Lists differ: ['/bin/bash', '--login', '--no... !=
['/bin/bash', '--login', '--no...
First differing element 4:
ambari-sudo.sh su test_user -l -s /bin/bash -c 'export
PATH='"'"'/home/i/.pythonbrew/bin:/home/i/.pythonbrew/pythons/Python-2.6/bin:/home/i/work_env/alternatives/jdk7/bin:/home/i/work_env/apache-maven-3.0.5/bin:/home/i/.pyenv/shims:/home/i/.pyenv/bin:/home/i/work_env/alternatives/jdk7/bin:/home/i/work_env/alternatives/maven31/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/home/i/Portfolio/work/java_env/apache-maven-3.0.2/bin:/home/i/bin:/media/development/work/irobot/snippets/bin/::~/.nvm/v0.10.31/bin/:~/.nvm/v0.10.31/lib/node_modules/brunch/bin/:/home/i/work_env/android-sdk-linux/tools:/home/i/work_env/android-sdk-linux/platform-tools:/home/i/bin:/opt/scala/bin::/opt/scala/bin:/home/i/work_env/android-sdk-linux/tools:/home/i/work_env/android-sdk-linux/platform-tools:/bin'"'"'
JAVA_HOME=/test/java/home ; echo "1"'
ambari-sudo.sh su test_user -l -s /bin/bash -c 'export
PATH=/home/i/.pythonbrew/bin:/home/i/.pythonbrew/pythons/Python-2.6/bin:/home/i/work_env/alternatives/jdk7/bin:/home/i/work_env/apache-maven-3.0.5/bin:/home/i/.pyenv/shims:/home/i/.pyenv/bin:/home/i/work_env/alternatives/jdk7/bin:/home/i/work_env/alternatives/maven31/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/home/i/Portfolio/work/java_env/apache-maven-3.0.2/bin:/home/i/bin:/media/development/work/irobot/snippets/bin/::~/.nvm/v0.10.31/bin/:~/.nvm/v0.10.31/lib/node_modules/brunch/bin/:/home/i/work_env/android-sdk-linux/tools:/home/i/work_env/android-sdk-linux/platform-tools:/home/i/bin:/opt/scala/bin::/opt/scala/bin:/home/i/work_env/android-sdk-linux/tools:/home/i/work_env/android-sdk-linux/platform-tools:/bin
JAVA_HOME=/test/java/home ; echo "1"'
Diff is 2614 characters long. Set self.maxDiff to None to see it.
----------------------------------------------------------------------
Ran 403 tests in 16.322s
FAILED (failures=1)
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [1.809s]
[INFO] Ambari Metrics Common ............................. SUCCESS [0.765s]
[INFO] Ambari Server ..................................... SUCCESS [38.607s]
[INFO] Ambari Agent ...................................... FAILURE [17.152s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
Thanks,
Dmitro Lisnichenko
