----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35835/#review89223 -----------------------------------------------------------
Ship it! Ship It! - Robert Levas On June 24, 2015, 2:12 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35835/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 2:12 p.m.) > > > Review request for Ambari, Nate Cole and Robert Levas. > > > Bugs: AMBARI-12129 > https://issues.apache.org/jira/browse/AMBARI-12129 > > > Repository: ambari > > > Description > ------- > > An earlier change to view DataStore entity String fields mapped to CLOB type > does not work well because CLOB types can not be part of a WHERE clause. > > DataStore was meant to be a lightweight persistence mechanism for views so it > should be okay to impose reasonable limitations on the entities that it > stores. > > For view entity String types we will use VARCHAR and limit the length to 4000 > characters. An exception will be thrown if a String that exceeds that length > is submitted. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java > 69328e7 > > ambari-server/src/test/java/org/apache/ambari/server/view/persistence/DataStoreImplTest.java > d623a26 > > Diff: https://reviews.apache.org/r/35835/diff/ > > > Testing > ------- > > Manual tested. > > Updated unit tests. > > mvn clean test > > all pass > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 52:13 min > [INFO] Finished at: 2015-06-24T12:16:54-04:00 > [INFO] Final Memory: 57M/1476M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
