-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35900/#review89493
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 (line 133)
<https://reviews.apache.org/r/35900/#comment142125>

    Reword a bit.  Should make clear that a Restart is not sufficient since 
that "custom" command does not affect states.  Maybe "The following services 
should be in a started state.  Please invoke a service Stop and full Start and 
try again."  (edit as you see fit)



ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
 (line 92)
<https://reviews.apache.org/r/35900/#comment142126>

    Inappropriate text on a getFailedOn().  For services, it has to be the 
service name.  For properties, it's the property names etc.  The idea was that 
it's the internal name in case the UI wanted to provide links to pages based on 
the service name (for example).  For messages, build a single text line and use 
the setFailReason(String) method.


- Nate Cole


On June 25, 2015, 9:19 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35900/
> -----------------------------------------------------------
> 
> (Updated June 25, 2015, 9:19 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Jonathan Hurley, 
> Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-12150
>     https://issues.apache.org/jira/browse/AMBARI-12150
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> 1. Installed Ambari 2.1.0 at build 2216
> 2. Deployed a 5 node cluster with HDP 2.2.7 and HDFS, MR, YARN, Tez, Pig, 
> Oozie.
> 3. Enabled NameNode HA and ResourceManager HA
> 4. Registered version 2.3.0.0-2425
> 5. Attempted to start RU
> 6. Pre Checks failed stating that services were down when they were clearly 
> not
> Note: Doing a Stop All Services and Start All remedied it. Restarting Ambari 
> Server did not fix it since the states in the DB are inconsistent.
> There's nothing that jumps out at me in the ambari-server logs; there are 
> error messages, but not related.
> 
> 
> Diffs
> -----
> 
>   ambari-server/pom.xml 6aa62f2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  23a575a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  243b26d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentDesiredStateDAO.java
>  2d699b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java
>  e7b5c10 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java
>  570c84b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
>  dabe98b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/models/HostComponentSummary.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
>  65c37f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  560cd04 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java
>  c59ded4 
> 
> Diff: https://reviews.apache.org/r/35900/diff/
> 
> 
> Testing
> -------
> 
> On the cluster where the issue happened, I replaced the jar file and was able 
> to move forward.
> 
> Unit tests are in progress.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Reply via email to