----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36004/#review89764 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 41) <https://reviews.apache.org/r/36004/#comment142564> Are pig-client, hadoop-hdfs-client, hadoop-mapreduce-client, hadoop-yarn-client needed? ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 122) <https://reviews.apache.org/r/36004/#comment142557> Would a dry_run return the conf name that would have been created? ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 214) <https://reviews.apache.org/r/36004/#comment142559> Safer to call upper() during comparison and before calling split, make sure that stack_id is not None. ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py (line 46) <https://reviews.apache.org/r/36004/#comment142562> This is the version either upgrading/downgrading to. In the case of a downgrade to 2.2.*, the link_config function will not be called. May need to use config['hostLevelParams']['stack_version'] instead, which is the starting stack, e.g., HDP-2.2 - Alejandro Fernandez On June 29, 2015, 5:31 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36004/ > ----------------------------------------------------------- > > (Updated June 29, 2015, 5:31 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and > Jonathan Hurley. > > > Bugs: AMBARI-12201 > https://issues.apache.org/jira/browse/AMBARI-12201 > > > Repository: ambari > > > Description > ------- > > * Fresh install of HDP-2.3 should use versioned config and symlink > /etc/[component]/conf to /usr/hdp/current/[component-client-dir]/conf to > /etc/[component]/[version]/0 > * When upgrading to HDP-2.3 (from either -2.2 or -2.3), invoke conf-select on > known directories on install. > > > Diffs > ----- > > ambari-common/src/main/python/resource_management/core/shell.py 75d4e56 > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > 37b455d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py > d2855b1 > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py > 1bd82ae > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > 8d1c07f > ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py > 2f2a518 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py > 71ac3df > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py > 170f72e > ambari-server/src/test/python/custom_actions/test_ru_set_all.py d9e8c70 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py ded432b > > ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py > fa3f717 > ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py d26813a > > Diff: https://reviews.apache.org/r/36004/diff/ > > > Testing > ------- > > Testing Done > Several manual scenarios: > * Fresh install of HDP-2.3 (no upgrade) > * Upgrade HDP-2.3 to HDP-2.3+ > * Upgrade HDP-2.2 to HDP-2.3 > * (Pending) Downgrade HDP-2.3 to HDP-2.3- > * (Pending) Downgrade HDP-2.3 to HDP-2.2 > > Automated: > Total run:768 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Nate Cole > >
