-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35352/
-----------------------------------------------------------
(Updated July 3, 2015, 8:50 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
Bugs: AMBARI-11810
https://issues.apache.org/jira/browse/AMBARI-11810
Repository: ambari
Description
-------
All the rolling upgrade pre-checks may still need to run against a non-HDP
stack. Use this JIRA to make the check runnable based on properties
(rollingupgrade.stack, rollingupgrade.version) set in the
/etc/ambari-server/conf/ambari.properties. Still default to HDP and 2.2.4.2 if
the properties do not exist.
org.apache.ambari.server.checks.AbstractCheckDescriptor compares stack against
hardcoded StackInfo "HDP-2.2". the stack name and version info can be
externalized into the /etc/ambari-server/conf/ambar.properties in order to
support non-HDP stacks.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
8cabf29
ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
4834cee
Diff: https://reviews.apache.org/r/35352/diff/
Testing (updated)
-------
Added new unit tests
Manual test
1. Verify that without the fix, no rolling upgrade prechecks ran, the Ambari
web UI popped open a dialog showing all the rolling upgrade precheck as
failures.
2. with the fix, the prechecks ran, I got to see a warning dialog suggesting me
to enable HA for hive metastore as well as showing me hive/hadoop properties
that RU will modify.
Thanks,
Di Li
