----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36117/#review90612 -----------------------------------------------------------
Ship it! Ship It! - Mahadev Konar On July 2, 2015, 12:47 a.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36117/ > ----------------------------------------------------------- > > (Updated July 2, 2015, 12:47 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Mahadev Konar, > and Yusaku Sako. > > > Bugs: AMBARI-12248 > https://issues.apache.org/jira/browse/AMBARI-12248 > > > Repository: ambari > > > Description > ------- > > When I access the Host Details page for : > {code} > http://172.22.76.13:8080/api/v1/clusters/leapsec/hosts/leapsec-rhel6-11.openstacklocal?fields=metrics/cpu/cpu_user[1436028521,1436032121,15],metrics/cpu/cpu_wio[1436028521,1436032121,15],metrics/cpu/cpu_nice[1436028521,1436032121,15],metrics/cpu/cpu_aidle[1436028521,1436032121,15],metrics/cpu/cpu_system[1436028521,1436032121,15],metrics/cpu/cpu_idle[1436028521,1436032121,15]&_=1435698892786 > {code} > > However, look at the screenshot. The start time (1435946268) and using the > standard +3600 seconds for the end time (1435949868), the following call was > made: > {code} > http://172.22.76.13:8080/api/v1/clusters/leapsec/hosts/leapsec-rhel6-11.openstacklocal?fields=metrics/cpu/cpu_user[1435946268,1435949868,15],metrics/cpu/cpu_wio[1435946268,1435949868,15],metrics/cpu/cpu_nice[1435946268,1435949868,15],metrics/cpu/cpu_aidle[1435946268,1435949868,15],metrics/cpu/cpu_system[1435946268,1435949868,15],metrics/cpu/cpu_idle[1435946268,1435949868,15]&_=1435698626557 > {code} > > This resulted in 13.6MB of data transferred in 12.05s. The result set size > is exactly consistent with what is in the screenshot. > Note that this result set contained a bunch of data that are *outside* of the > time window specified [1435946268,1435949868). > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > d018f29 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java > d1483ea > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java > 71f53ca > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java > 643e5cc > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java > 133c8b5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TemporalInfoImpl.java > bce228f > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricReportingAdapter.java > d015097 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDownsamplingMethod.java > 8e96a42 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDownsamplingMethodFactory.java > f7d3457 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java > b87118b > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java > 2dbff68 > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/TemporalInfo.java > dca61be > > ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/TestStreamProvider.java > 07fa7c7 > > ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java > 859fda4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProviderTest.java > c0ce419 > > ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/MetricsPaddingMethodTest.java > 7665e5e > ambari-server/src/test/resources/ams/single_host_component_metrics.json > b8c4e24 > > Diff: https://reviews.apache.org/r/36117/diff/ > > > Testing > ------- > > All unit test passed. > Deployred 3 node cluster and verified AMS working fine with HDFS, YARN, HBASE. > > > Thanks, > > Sid Wagle > >
