> On July 7, 2015, 7:40 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py, > > line 64 > > <https://reviews.apache.org/r/36272/diff/1/?file=1001719#file1001719line64> > > > > How much work would it take to add Phoenix Client as a proper > > component, and add it to the Upgrade Pack? > > > > I'm concerned that this will only update the symlink when Phoenix > > Client is also on this HBase client host. So we can end up in a situation > > where the cluster has HDP 2.2 for phoenix client, and 2.3 for all other > > components on all hosts, and this presents a problem after RU, or during > > the next major RU. > > Sumit Mohanty wrote: > There is a call to hdp-select set all during finalize. Till then there is > a mix of two versions across various components on various hosts. Won't > select set all fix this for all instances of phoenix-client? > > Alejandro Fernandez wrote: > Preference is to move the "hdp-select set all" step in the Upgrade Pack > to its own group, right before the Finalize group. This will be a catch-all > that will handle things like Phoenix Client, assuming that its configs are > correct if the host contains any other clients. Ultimately, we will need to > have Phoenix Client as a proper Component once we are ready for it. > > Sumit Mohanty wrote: > Agreed. Let me open a separate JIRA for the hdp-select set all to be a > separate step during upgrade before Finalize. This change need to go in with > changes to make sure that conf folders are also set up correctly for all > services whether they are managed by Ambari or not. For HDP-2.3, > phoenix-client is used from the host that has hbase-client as there are no > hosts as such for phoenix-client. Also, phoenix is always deployed with hbase.
Having "hdp-select set all" in its own group right before Finalize will make this Jira redundant, and probably involve the same number of lines. I do believe we need a separate Jira to make PhoenixClient a proper component. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36272/#review90764 ----------------------------------------------------------- On July 7, 2015, 6:59 p.m., Sumit Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36272/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 6:59 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Nate Cole. > > > Bugs: AMBARI-12316 > https://issues.apache.org/jira/browse/AMBARI-12316 > > > Repository: ambari > > > Description > ------- > > Phoenix system tests fail before finalize - phoenix-client still points to > older version after upgrade but before finalize > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py > 9036bb3 > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py > cf923f1 > > Diff: https://reviews.apache.org/r/36272/diff/ > > > Testing > ------- > > Ran unit tests and manually tested through upgrade and downgrade > > > Thanks, > > Sumit Mohanty > >
