----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36313/#review90905 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On July 8, 2015, 10:52 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36313/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 10:52 a.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-12333 > https://issues.apache.org/jira/browse/AMBARI-12333 > > > Repository: ambari > > > Description > ------- > > this patch cause unit-test to be failing: > {code} > Results : > > Tests in error: > UpgradeResourceProviderTest.testCreatePartialDowngrade:428 ? NullPointer > > Tests run: 3111, Failures: 0, Errors: 1, Skipped: 28 > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [6.409s] > [INFO] Ambari Metrics Common ............................. SUCCESS [3.909s] > [INFO] Ambari Server ..................................... FAILURE > [1:16:42.534s] > [INFO] Ambari Agent ...................................... SKIPPED > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:16:57.150s > [INFO] Finished at: Wed Jul 08 10:34:40 UTC 2015 > [INFO] Final Memory: 39M/826M > [INFO] > ------------------------------------------------------------------------ > {code} > > Short debugging shows, that error is in UpgradeResourceProvider.java: > {code} > UpgradeEntity lastUpgradeItemForCluster = > s_upgradeDAO.findLastUpgradeForCluster(cluster.getClusterId()); > ctx.setDowngradeFromVersion(lastUpgradeItemForCluster.getToVersion()); > {code} > {{lastUpgradeItemForCluster}} is null > > > Diffs > ----- > > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 1b6ad36 > > Diff: https://reviews.apache.org/r/36313/diff/ > > > Testing > ------- > > Verified UpgradeResourceProviderTest is fixed. > > > Thanks, > > Jonathan Hurley > >
