> On July 8, 2015, 2:29 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/themes/theme.json, > > lines 10-11 > > <https://reviews.apache.org/r/36302/diff/1/?file=1002100#file1002100line10> > > > > Do we need to keep these in the 2.3 theme when they don't exist as a > > property?
Yes, exactly! The main thing is that theme.json file inherited from stack to stack per section. If we do not redifine that section to null(this will exlude them from resulting response), we would see widged for unexisted property. So, yes - we need this, indeed. > On July 8, 2015, 2:29 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HBASE/themes/theme.json, > > lines 28-29 > > <https://reviews.apache.org/r/36302/diff/1/?file=1002104#file1002104line28> > > > > In 2.3? Yes, exactly! The main thing is that theme.json file inherited from stack to stack per section. If we do not redifine that section to null(this will exlude them from resulting response), we would see widged for unexisted property. So, yes - we need this, indeed. > On July 8, 2015, 2:29 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml, > > lines 684-688 > > <https://reviews.apache.org/r/36302/diff/1/?file=1002097#file1002097line684> > > > > Don't use a new task for this - just delete the properties in the HBase > > class that you're using to manipluate the values. The base idea for the HBase class was to make calculations, separate task make the whole process more clear and transparent, but ok.. - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36302/#review90897 ----------------------------------------------------------- On July 8, 2015, 3:10 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36302/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 3:10 p.m.) > > > Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-12224 > https://issues.apache.org/jira/browse/AMBARI-12224 > > > Repository: ambari > > > Description > ------- > > HBase has deprecated hbase.regionserver.global.memstore.upperLimit and > hbase.regionserver.global.memstore.lowerLimit for HDP-2.3 in favor of > hbase.regionserver.global.memstore.size and > hbase.regionserver.global.memstore.size.lower.limit. > The slider called "% of RegionServer Allocated to Write Buffers" sets > hbase.regionserver.global.memstore.size, while > hbase.regionserver.global.memstore.upperLimit is in the advanced > configuration section. This leaves two bugs: > In HDP-2.2, the slider has no affect since HBase basically ignores the > parameter. > In HDP-2.3 the value set by the slider also has no affect since the > deprecated values set take precedence. > One solution is to get rid of hbase.regionserver.global.memstore.upperLimit > and hbase.regionserver.global.memstore.lowerLimit in advanced settings in > Ambari, and make the slider configuration to use > hbase.regionserver.global.memstore.upperLimit in HDP-2.2 and > hbase.regionserver.global.memstore.size in HDP-2.3. Rolling upgrade can > convert these settings. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HBaseConfigCalculation.java > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/themes/theme.json > 53da86d > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > c5fb156 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/hbase-site.xml > 12cd44b > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/metainfo.xml > 921a225 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/themes/theme.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HBASE/themes/theme.json > 1808809 > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HBASE/configuration/hbase-site.xml > 43f872a > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HBASE/metainfo.xml > aa169df > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HBASE/themes/theme.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/36302/diff/ > > > Testing > ------- > > manual checks > Tests in error: > UpgradeResourceProviderTest.testCreatePartialDowngrade:428 ? NullPointer > > Tests run: 3111, Failures: 0, Errors: 1, Skipped: 28 > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [6.409s] > [INFO] Ambari Metrics Common ............................. SUCCESS [3.909s] > [INFO] Ambari Server ..................................... FAILURE > [1:16:42.534s] > [INFO] Ambari Agent ...................................... SKIPPED > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:16:57.150s > [INFO] Finished at: Wed Jul 08 10:34:40 UTC 2015 > [INFO] Final Memory: 39M/826M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
