----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36331/#review90988 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (lines 207 - 210) <https://reviews.apache.org/r/36331/#comment144165> This is a bit confusing to understand what it's doing and why it's necessary. Can you add some comments around it? ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 313) <https://reviews.apache.org/r/36331/#comment144167> Do you need an `elif` here? If len(dirs) != 0, then it has to be > 0, right? ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py (line 91) <https://reviews.apache.org/r/36331/#comment144170> commented out? ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py (line 94) <https://reviews.apache.org/r/36331/#comment144171> commented out? ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py (line 147) <https://reviews.apache.org/r/36331/#comment144173> Merge conflict? - Jonathan Hurley On July 8, 2015, 4:56 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36331/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 4:56 p.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-12341 > https://issues.apache.org/jira/browse/AMBARI-12341 > > > Repository: ambari > > > Description > ------- > > Added: > * pig > * flume > * storm-slider-client > * verified kafka still worked after stack change > * hive-hcatalog and hive-webhcat, which is the only multi-directory for > conf-select, thus changing the structures > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > 8b3f930 > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py > 5d2eea5 > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py > 7dc57a4 > ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py > a6f7c28 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py > 24b3ec8 > ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_client.py 8825248 > > ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py > 572cd11 > > Diff: https://reviews.apache.org/r/36331/diff/ > > > Testing > ------- > > Full cluster install, full install packages for new version, upgrade to > confirm ru_set_all.py is correct after running. > > Automated (python changes only): > ---------------------------------------------------------------------- > Total run:768 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Nate Cole > >
