----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36340/#review91028 -----------------------------------------------------------
ambari-simulator/Common/os_check.py (line 1) <https://reviews.apache.org/r/36340/#comment144271> Later, we can import this file from ambari_common. For now, ok to duplicate it. ambari-simulator/Docker/__init__.py (line 1) <https://reviews.apache.org/r/36340/#comment144270> Can remove the author tag. ambari-simulator/cluster.py (line 1) <https://reviews.apache.org/r/36340/#comment144256> To all of these files, we'll add the header that states the open source license. E.g., """ Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. """ ambari-simulator/cluster.py (line 17) <https://reviews.apache.org/r/36340/#comment144257> Safer to use, with open(filename, "r") as f: #... For now, leave as is. In a future patch, you can start using that style. ambari-simulator/cluster.py (line 54) <https://reviews.apache.org/r/36340/#comment144262> To make this more readable, we'll use "gce up {0} {1} {2}".format(cluster_name, vms_num, foo) ambari-simulator/cluster.py (line 58) <https://reviews.apache.org/r/36340/#comment144263> Typo ambari-simulator/cluster.py (line 78) <https://reviews.apache.org/r/36340/#comment144264> For all of these file open/writes, should use the with open() as f: notation ambari-simulator/config/cluster.txt (line 1) <https://reviews.apache.org/r/36340/#comment144269> Is this file needed? ambari-simulator/config/config.ini (line 34) <https://reviews.apache.org/r/36340/#comment144268> What's in this image? ambari-simulator/output/gce_info_output.txt (line 1) <https://reviews.apache.org/r/36340/#comment144267> Build artifact? ambari-simulator/test/cluster.txt (line 1) <https://reviews.apache.org/r/36340/#comment144266> Is this also an artifact of running tests? ambari-simulator/test/test.txt (line 1) <https://reviews.apache.org/r/36340/#comment144265> Is this file needed or is it an artifact? - Alejandro Fernandez On July 9, 2015, 12:17 a.m., Pengcheng Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36340/ > ----------------------------------------------------------- > > (Updated July 9, 2015, 12:17 a.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-12339 > https://issues.apache.org/jira/browse/AMBARI-12339 > > > Repository: ambari > > > Description > ------- > > Initial commit for scale testing with multiple docker containers, each > hosting an ambari agent. > > > Diffs > ----- > > ambari-simulator/Common/__init__.py PRE-CREATION > ambari-simulator/Common/os_check.py PRE-CREATION > ambari-simulator/Common/os_family.json PRE-CREATION > ambari-simulator/Docker/Dockerfile PRE-CREATION > ambari-simulator/Docker/__init__.py PRE-CREATION > ambari-simulator/Docker/ambari_agent_start.sh PRE-CREATION > ambari-simulator/Docker/launcher_agent.py PRE-CREATION > ambari-simulator/Linux/CentOS7/docker_install.sh PRE-CREATION > ambari-simulator/Linux/CentOS7/weave_install.sh PRE-CREATION > ambari-simulator/Linux/Ubuntu12/docker_install.sh PRE-CREATION > ambari-simulator/Linux/Ubuntu12/weave_install.sh PRE-CREATION > ambari-simulator/cluster.py PRE-CREATION > ambari-simulator/config.py PRE-CREATION > ambari-simulator/config/cluster.txt PRE-CREATION > ambari-simulator/config/config.ini PRE-CREATION > ambari-simulator/config/hosts.txt PRE-CREATION > ambari-simulator/docker.py PRE-CREATION > ambari-simulator/launcher_cluster.py PRE-CREATION > ambari-simulator/launcher_docker.py PRE-CREATION > ambari-simulator/output/gce_info_output.txt PRE-CREATION > ambari-simulator/server_setup.sh PRE-CREATION > ambari-simulator/test/cluster.txt PRE-CREATION > ambari-simulator/test/test.txt PRE-CREATION > ambari-simulator/test/test_vm.py PRE-CREATION > ambari-simulator/tips.txt PRE-CREATION > ambari-simulator/vm.py PRE-CREATION > > Diff: https://reviews.apache.org/r/36340/diff/ > > > Testing > ------- > > Manually tested on Google Compute > > > Thanks, > > Pengcheng Xu > >
