----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36541/#review91876 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On Липень 16, 2015, 9:24 до полудня, Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36541/ > ----------------------------------------------------------- > > (Updated Липень 16, 2015, 9:24 до полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-12430 > https://issues.apache.org/jira/browse/AMBARI-12430 > > > Repository: ambari > > > Description > ------- > > While upgrading the cluster, there were many properties that were missing in > Ambari properties file. This is 1.7/2.2 stack -> 2.0/2.2.4 stack -> 2.1/2.3 > stack upgrade. There should be some checking to ensure the critical properties > are present and addition of properties that are required but missing. > > Without this we're just hoping all the properties are there and otherwise user > gets an error that they cannot make sense of and requires manual intervention > from Ambari team. > > > Diffs > ----- > > ambari-server/src/main/python/ambari_server/serverConfiguration.py cf7ab4b > ambari-server/src/main/python/ambari_server_main.py bc561a1 > ambari-server/src/test/python/TestAmbariServer.py db16927 > > Diff: https://reviews.apache.org/r/36541/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
