----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36638/#review92400 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On Липень 21, 2015, 12:29 після полудня, Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36638/ > ----------------------------------------------------------- > > (Updated Липень 21, 2015, 12:29 після полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-12473 > https://issues.apache.org/jira/browse/AMBARI-12473 > > > Repository: ambari > > > Description > ------- > > These checks should probably check if os_version >= 7 not only 7 for avoiding > issues in future. Also we should get rid of such a function to avoid such a > code. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/Facter.py 20b0447 > ambari-agent/src/test/python/ambari_agent/TestController.py ba6e6c8 > ambari-agent/src/test/python/ambari_agent/TestHardware.py 29870d5 > ambari-agent/src/test/python/ambari_agent/TestRegistration.py c6aa019 > ambari-common/src/main/python/ambari_commons/os_check.py 904a23b > ambari-server/src/main/python/ambari_server/utils.py 2afcd1b > > Diff: https://reviews.apache.org/r/36638/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
