> On July 22, 2015, 8:46 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml, > > lines 86-88 > > <https://reviews.apache.org/r/36665/diff/1/?file=1018243#file1018243line86> > > > > Do we also need for 2.2.x -> 2.2.y? Does this ZKFC logic apply for > > 2.2.x (if this is recent, we may need to adjust) > > Alejandro Fernandez wrote: > You're right, I'll provide an add-on patch.
Just attached an additional patch to this code review. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36665/#review92645 ----------------------------------------------------------- On July 21, 2015, 11:14 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36665/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 11:14 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, > and Srimanth Gunturi. > > > Bugs: AMBARI-12488 > https://issues.apache.org/jira/browse/AMBARI-12488 > > > Repository: ambari > > > Description > ------- > > Currently RU orchestration during upgrade/downgrade kills ZKFC on the active > NameNode to initiate a failover to standby. We should instead use the > failover command. > E.g., > > su hdfs -c 'hdfs haadmin -failover nn1 nn2' > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py > 827c03d > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py > b15bdc4 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > 94d5b43 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py > a185b5f > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 5cc30b2 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml > ba16159 > > Diff: https://reviews.apache.org/r/36665/diff/ > > > Testing > ------- > > Tested this during an RU, in which the active NameNode did successfully > initiate an ha failover by calling the command. > > Python unit tests passed. > > ----------------------------------------------------------------------- > Total run:803 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
