> On July 24, 2015, 1:06 p.m., Nate Cole wrote: > > Is there a test that can be added to? I know it's a small change, so > > should be pretty straightforward.
Checks have no UT coverage at all. Will be covered as a separate issue for all RU pre-req checks - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36775/#review92902 ----------------------------------------------------------- On July 24, 2015, 12:12 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36775/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 12:12 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-12524 > https://issues.apache.org/jira/browse/AMBARI-12524 > > > Repository: ambari > > > Description > ------- > > Installed HDP 2.2 cluster, then installed HDP 2.3. clicked perform upgrade. > The prerequisite checks had a couple issues: > 1) The Hive Metastore warning is missing "Failed on:" text. Should that have > said "HIVE"? > 2) The config changes, show changing the yarn.admin.acl. I used custom > service account name "jyarn" so it looks like it will preserve my setting in > the Resulting Value (which is correct and good). But including this diff > seemed strange. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheck.java > 5b3e2a0 > > Diff: https://reviews.apache.org/r/36775/diff/ > > > Testing > ------- > > - > [09:29:15][Step 1/1] [INFO] Reactor Summary: > [09:29:15][Step 1/1] [INFO] > [09:29:15][Step 1/1] [INFO] Ambari Views > ...................................... SUCCESS [3.978s] > [09:29:15][Step 1/1] [INFO] Ambari Metrics Common > ............................. SUCCESS [1.654s] > [09:29:15][Step 1/1] [INFO] Ambari Server > ..................................... SUCCESS [59:01.721s] > [09:29:15][Step 1/1] [INFO] > ------------------------------------------------------------------------ > [09:29:15][Step 1/1] [INFO] BUILD SUCCESS > [09:29:15][Step 1/1] [INFO] > ------------------------------------------------------------------------ > [09:29:15][Step 1/1] [INFO] Total time: 59:08.044s > [09:29:15][Step 1/1] [INFO] Finished at: Fri Jul 24 09:50:46 UTC 2015 > [09:29:16][Step 1/1] [INFO] Final Memory: 52M/1338M > [09:29:16][Step 1/1] [INFO] > ------------------------------------------------------------------------ > [09:29:16][Step 1/1] Process exited with code 0 > > > Thanks, > > Dmitro Lisnichenko > >
