----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37145/#review94324 -----------------------------------------------------------
Ship it! Ship It! - Srimanth Gunturi On Aug. 5, 2015, 9:42 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37145/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 9:42 p.m.) > > > Review request for Ambari, Srimanth Gunturi and Yusaku Sako. > > > Bugs: AMBARI-12653 > https://issues.apache.org/jira/browse/AMBARI-12653 > > > Repository: ambari > > > Description > ------- > > *STR:* > # Issue browser Refresh on Hosts Page > # Click on Add Host link and launch add host wizard > # On Clicking deploy button on Review page, API to create service component > for an existing service component is triggered which fails with 409 error > code. Thus user gets stuck at Review page > > *Expected Result:* Attempt to create service components should be done only > if a service is missing any service component. > > > #Cause of the issue:# > This happen because servicecomponents mapping in the service ember model was > not getting updated until serviceMetrics API call was loaded one time more > after the initial load (This was a bug in the sequence of how we do initial > load). Also service metrics is not polled on Hosts page. So refreshing on > hosts page and then launching add host wizard does not map service with > service components and add host wizard tries to create all service components > again > > > Diffs > ----- > > ambari-web/app/controllers/global/cluster_controller.js b9d9711 > ambari-web/app/mappers/components_state_mapper.js 64d00de > ambari-web/app/mappers/service_metrics_mapper.js 6f4531f > ambari-web/app/routes/add_host_routes.js 7bfe04c > ambari-web/app/utils/components.js 74f0a33 > ambari-web/test/controllers/main/host/details_test.js 76d1835 > > Diff: https://reviews.apache.org/r/37145/diff/ > > > Testing > ------- > > Tested tha patch manually on a cluster > Verified that all unit tests for ambari-web passess: > > 6701 tests complete (12 seconds) > 94 tests pending > > > Thanks, > > Jaimin Jetly > >
