----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37185/#review94401 -----------------------------------------------------------
Ship it! Ship It! - Dmytro Sen On Авг. 6, 2015, 2:12 п.п., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37185/ > ----------------------------------------------------------- > > (Updated Авг. 6, 2015, 2:12 п.п.) > > > Review request for Ambari and Dmytro Sen. > > > Bugs: AMBARI-12662 > https://issues.apache.org/jira/browse/AMBARI-12662 > > > Repository: ambari > > > Description > ------- > > Ambari is overwriting the contents of whatever net.topology.script.file.name > is set to. This makes it impossible for a user to manage topology scripts on > their own (if they have an existing script, it keeps getting blown over) > > <https://github.com/apache/ambari/blob/trunk/ambari- > server/src/main/resources/stacks/HDP/2.0.6/hooks/before- > START/scripts/params.py#L197> > > Regardless if net.topology.script.file.name is set, Ambari should only manage > /etc/hadoop/conf/topology.py and NOT read the net.topology.script.file.name > property and overwrite that file's content. If a user chooses to manage their > own topology script and set that property accordingly, they should be ok doing > that and Ambari should not touch it. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py > 3ddefe3 > > Diff: https://reviews.apache.org/r/37185/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
