[
https://issues.apache.org/jira/browse/AMBARI-12684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14663217#comment-14663217
]
Hadoop QA commented on AMBARI-12684:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12749440/AMBARI-12684.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-admin.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/3550//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/3550//console
This message is automatically generated.
> Ambari web stylesheet should be overridable on build time
> ---------------------------------------------------------
>
> Key: AMBARI-12684
> URL: https://issues.apache.org/jira/browse/AMBARI-12684
> Project: Ambari
> Issue Type: Task
> Components: ambari-web
> Affects Versions: 2.1.1
> Reporter: Jaimin D Jetly
> Assignee: Jaimin D Jetly
> Fix For: 2.1.1
>
> Attachments: AMBARI-12684.patch
>
>
> As part of this ticket css order of concatenation is set in a way that if
> following files are dropped at build time, they will be the last to get
> concatenated making selectors defined in them override any ambari css
> selector:
> # *custom-ui.less* file should be dropped in *ambari/ambari-web/app/styles/*
> directory
> # *custom-admin-ui.css* file should be dropped in
> *ambari-admin/src/main/resources/ui/admin-web/app/styles/* directory
> Since all the CSS related attributes are defined in the stylesheets and not
> in html/templates in ambari, This gives an ability to override the look and
> feel of ambari and ambari-admin view by simply dropping stylesheet with
> desired changes as pointed above.
> NOTE: Since ambari uses RAT plugin in its maven build, these stylesheets
> being dropped before compilation should have apache header or else maven
> build will fail complaining about missing apache license
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
