----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37216/#review94990 -----------------------------------------------------------
Ship it! Ship It! - Srimanth Gunturi On Aug. 7, 2015, 1:09 p.m., Rohit Choudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37216/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2015, 1:09 p.m.) > > > Review request for Ambari, Erik Bergenholtz and Mahadev Konar. > > > Bugs: https://issues.apache.org/jira/browse/AMBARI-12671 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-12671 > > > Repository: ambari > > > Description > ------- > > The problem was that when error in the middle of execution appears, it > returned in the statusMessage field, and since it contains stack trace, it's > too long to store it in database. That's why we got exception from database. > This fix makes change that statusMessage will not be stored in database. > Hence, once it returned to user, it will be shown on the UI but will not be > persisted. > So, instead of 500 error UI will receive JSON with "status: Failed" and will > not stuck on updating status. > > > Diffs > ----- > > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobImpl.java > 317b791 > > Diff: https://reviews.apache.org/r/37216/diff/ > > > Testing > ------- > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.411 sec > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running org.apache.ambari.view.hive.PropertyValidatorTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.14 sec > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running org.apache.ambari.view.hive.resources.files.FileServiceTest > Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.016 sec > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest > Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.208 sec > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.17 sec > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.941 sec > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running org.apache.ambari.view.hive.resources.jobs.LogParserTest > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.07 sec > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running > org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.602 sec > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running > org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.138 sec > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running > org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest > Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.973 sec > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.615 sec > > Results : > > Tests run: 48, Failures: 0, Errors: 0, Skipped: 0 > > [INFO] > [INFO] --- apache-rat-plugin:0.11:check (default) @ hive --- > [INFO] 51 implicit excludes (use -debug for more details). > [INFO] Exclude: .git/ > [INFO] Exclude: **/.gitignore > [INFO] Exclude: **/.gitattributes > [INFO] Exclude: .idea/ > [INFO] Exclude: pass.txt > [INFO] Exclude: .DS_Store > [INFO] Exclude: .iml/ > [INFO] Exclude: .classpath > [INFO] Exclude: .project > [INFO] Exclude: .settings > [INFO] Exclude: **/target/** > [INFO] Exclude: **/.gitkeep > [INFO] Exclude: **/.bowerrc > [INFO] Exclude: **/.editorconfig > [INFO] Exclude: **/.jshintrc > [INFO] Exclude: **/.tmp/** > [INFO] Exclude: **/tmp/** > [INFO] Exclude: **/*.json > [INFO] Exclude: **/*.svg > [INFO] Exclude: **/vendor/** > [INFO] Exclude: **/bin > [INFO] Exclude: **/node_modules/** > [INFO] Exclude: **/vendor/** > [INFO] Exclude: **/public/** > [INFO] Exclude: **/dist/** > [INFO] Exclude: **/bower_components/** > [INFO] Exclude: **/bower/** > [INFO] Exclude: **/node/** > [INFO] Exclude: **/runner.js > [INFO] Exclude: **/assets/javascripts/** > [INFO] Exclude: **/assets/stylesheets/** > [INFO] Exclude: **/assets/static/javascripts/** > [INFO] Exclude: **/assets/static/stylesheets/** > [INFO] Exclude: storm/src/main/resources/** > [INFO] 308 resources included (use -debug for more details) > Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property > 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not > recognized. > Compiler warnings: > WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property > 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.' > Warning: org.apache.xerces.parsers.SAXParser: Feature > 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized. > Warning: org.apache.xerces.parsers.SAXParser: Property > 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized. > Warning: org.apache.xerces.parsers.SAXParser: Property > 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not > recognized. > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 307 licence. > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 41.690s > [INFO] Finished at: Fri Aug 07 18:27:56 IST 2015 > [INFO] Final Memory: 44M/524M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rohit Choudhary > >
