> On Aug. 11, 2015, 6:36 p.m., John Speidel wrote: > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java, > > line 304 > > <https://reviews.apache.org/r/37294/diff/3/?file=1037732#file1037732line304> > > > > I missed this when I originally looked at the patch, sorry about that. > > > > Why was this line removed? Without this line, the components returned > > from the logical requests will never be added to the map. We will always > > have a map of hosts to empty collections.
The v4 patch that has been attached to the review doesn't resolve the above issue as the line is still commented out but the patch that was merged appears to to be correct and includes the fix for this issue. - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37294/#review94960 ----------------------------------------------------------- On Aug. 11, 2015, 8:25 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37294/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2015, 8:25 p.m.) > > > Review request for Ambari, John Speidel and Robert Nettleton. > > > Bugs: AMBARI-12688 > https://issues.apache.org/jira/browse/AMBARI-12688 > > > Repository: ambari > > > Description > ------- > > This ticket is related to > https://issues.apache.org/jira/browse/AMBARI-10750 Initial merge of advanced > api provisioning work > Detailed scenario > 1. Deploy 3-node cluster from a blueprint (NameNode is on host1. Here NN is > mapped to host1 in the cluster topology) > 2. Enable NN HA (now NameNodes are on host1 and host2) > 3. Move NN from host1 to host3(now NameNodes are on host3 and host2, but > according to cluster topology NN also mapped to host1) > 4. HDFS service check fails > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java > b7f95cf > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java > 8e7fb7f > ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java > 3da0fe2 > > ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java > 5d84fbc > > ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java > 7cc70e8 > > Diff: https://reviews.apache.org/r/37294/diff/ > > > Testing > ------- > > [INFO] Ambari Server ..................................... SUCCESS > [1:14:15.296s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > > > Thanks, > > Dmytro Sen > >
