----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37573/#review95720 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java (line 137) <https://reviews.apache.org/r/37573/#comment150839> Should we optimize multiple "cluster.getDesiredConfigByType("hive-env") != null" to something like "bool isHiveSiteExist = cluster.getDesiredConfigByType("hive-site") != null; " ? ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java (line 206) <https://reviews.apache.org/r/37573/#comment150838> This unit-test is not present in 2.1.2 upgrade catalog, please drop - Dmytro Grinenko On Aug. 18, 2015, 9:29 a.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37573/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 9:29 a.m.) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-12801 > https://issues.apache.org/jira/browse/AMBARI-12801 > > > Repository: ambari > > > Description > ------- > > Removing defunct property in hive (hive.heapsize) causes hive metastore not > to start. > (template generation fails) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java > 77e2e93 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java > PRE-CREATION > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > d201df5 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > b78dd4b > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/37573/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
