----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37576/#review95734 -----------------------------------------------------------
Changes look good. Any unit tests that can be added? - Jayush Luniya On Aug. 18, 2015, 10:53 a.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37576/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 10:53 a.m.) > > > Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Sumit > Mohanty. > > > Bugs: AMBARI-12803 > https://issues.apache.org/jira/browse/AMBARI-12803 > > > Repository: ambari > > > Description > ------- > > Add sqla jdbc support for hive and oozie. > > > Diffs > ----- > > ambari-server/src/main/python/ambari-server.py 1b02162 > ambari-server/src/main/python/ambari_server/dbConfiguration.py fa8d6e3 > ambari-server/src/main/python/ambari_server/serverSetup.py 123ae3b > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > d201df5 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > 6081b39 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py > 1a6c6c1 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > b78dd4b > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml > d582581 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py > 35df33a > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py > a02594b > > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-env.xml > 17ce7a5 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml > 6d7434d > > ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/configuration/oozie-env.xml > 99ca2dc > > Diff: https://reviews.apache.org/r/37576/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
