----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37534/#review96178 -----------------------------------------------------------
Ship it! Ship It! - Srimanth Gunturi On Aug. 17, 2015, 2:31 p.m., Pallav Kulshreshtha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37534/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2015, 2:31 p.m.) > > > Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-12788 > https://issues.apache.org/jira/browse/AMBARI-12788 > > > Repository: ambari > > > Description > ------- > > checking the condition for empty query and showing an error on UI in case of > empty query. > > > Diffs > ----- > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js > 72fd37c > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visual-explain.js > 7ca6804 > contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js > af5e3a7 > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/visual-explain.hbs > a415b2c > > Diff: https://reviews.apache.org/r/37534/diff/ > > > Testing > ------- > > manually tested on local VM. Ran ember test to check of any breaking tests. > > > Thanks, > > Pallav Kulshreshtha > >
