> On Aug. 24, 2015, 12:05 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-config-changes-2.3.xml, > > lines 20-21 > > <https://reviews.apache.org/r/37682/diff/1/?file=1046777#file1046777line20> > > > > How do we reference this file from an Upgrade Pack? In addition, these > > target values would be unnecessary if the pack is already doing the same > > thing
we will have at least two different upgrade packs (upgrade-*.xml and nonrolling-upgrade-*.xml), and also cross-major-stack upgrades like 2.2 -> 2.4. So this file is going to be resolved automatically by the selected fields > On Aug. 24, 2015, 12:05 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-config-changes-2.3.xml, > > lines 27-29 > > <https://reviews.apache.org/r/37682/diff/1/?file=1046777#file1046777line27> > > > > Would prefer an ID or something instead of readable text. Please see a new design proposal published - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37682/#review96140 ----------------------------------------------------------- On Aug. 25, 2015, 10:41 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37682/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 10:41 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-12700 > https://issues.apache.org/jira/browse/AMBARI-12700 > > > Repository: ambari > > > Description > ------- > > The configs need to move out of the Upgrade Packs and into their own file. > This will make it easier to maintain, and clearer since there will not be any > dups. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-config-changes-2.3.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/37682/diff/ > > > Testing > ------- > > just published design > > > Thanks, > > Dmitro Lisnichenko > >
