-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37803/#review96773
-----------------------------------------------------------

Ship it!


Ship It!


ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 (line 121)
<https://reviews.apache.org/r/37803/#comment152419>

    It seems odd that this file is created in /var/lib/hadoop-yarn when it is 
really an Ambari-related file.  Are we sure we want to go in this direction?  I 
thought it was more appropriate to have it in the /var/lib/ambari-agent 
directory tree.



ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 (line 124)
<https://reviews.apache.org/r/37803/#comment152420>

    It seems odd that this file is created in /var/lib/hadoop-yarn when it is 
really an Ambari-related file.  Are we sure we want to go in this direction?  I 
thought it was more appropriate to have it in the /var/lib/ambari-agent 
directory tree.


- Robert Levas


On Aug. 27, 2015, 1:25 p.m., Ivan Kozlov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37803/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 1:25 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, Robert Levas, and 
> Vitalyi Brodetskyi.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PROBLEM: Ambari is overwriting ownership of yarn.local.dir with yarn:hadoop 
> in Kerberized cluster when it should be owned by running user . This happens 
> at restart of a nodemanager through Ambari. Only solution was to recreate 
> yarn.local.dir at which point it makes correct ownership of files. Restart 
> via Ambari then overwrites
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  9857d03 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  30629be 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 613ab69 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
> 428655b 
> 
> Diff: https://reviews.apache.org/r/37803/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Kozlov
> 
>

Reply via email to