----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37962/#review97115 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 183) <https://reviews.apache.org/r/37962/#comment152869> We should consider adding a unit test for it. The if condition seems quite fragile. - Sumit Mohanty On Aug. 31, 2015, 6:22 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37962/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2015, 6:22 p.m.) > > > Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Sumit > Mohanty. > > > Bugs: AMBARI-12947 > https://issues.apache.org/jira/browse/AMBARI-12947 > > > Repository: ambari > > > Description > ------- > > . > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-site.xml > e65c9ef > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 2d07726 > > Diff: https://reviews.apache.org/r/37962/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
