> On Сен. 7, 2015, 4:18 п.п., Sid Wagle wrote: > > Only comment: What about tolerance for old data that was value * 100? Is > > there any way to checkpoint?
In fact, no. Only check every metric value if value > 100, which is very recource consuming. Moreover, even if value < 100, let say it's 0.7, there is no garantee that it's an old value=70% it can be a new value=0.7% - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38156/#review97925 ----------------------------------------------------------- On Сен. 7, 2015, 2:18 п.п., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38156/ > ----------------------------------------------------------- > > (Updated Сен. 7, 2015, 2:18 п.п.) > > > Review request for Ambari, Myroslav Papirkovskyy, Sid Wagle, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-13024 > https://issues.apache.org/jira/browse/AMBARI-13024 > > > Repository: ambari > > > Description > ------- > > Some metrics are double-edited(on MetricsDataTransferMethodFactory and > sink/monitor side) > For instance, cpu-metrics are multiplied by 100 on monitor side, but divided > by MetricsDataTransferMethodFactory > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py > e0ed8e7 > > ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestHostInfo.py > bdedc2e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java > f265c4f > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricReportingAdapter.java > ad711f1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDataTransferMethod.java > 004742e > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDataTransferMethodFactory.java > 9d70158 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDownsamplingMethod.java > 8589a1b > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDownsamplingMethodFactory.java > 19df14c > > Diff: https://reviews.apache.org/r/38156/diff/ > > > Testing > ------- > > In progress > > > Thanks, > > Dmytro Sen > >
