----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38266/#review98474 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java (lines 118 - 121) <https://reviews.apache.org/r/38266/#comment154953> Sneaky! - Nate Cole On Sept. 10, 2015, 3:08 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38266/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2015, 3:08 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Nate Cole. > > > Bugs: AMBARI-13064 > https://issues.apache.org/jira/browse/AMBARI-13064 > > > Repository: ambari > > > Description > ------- > > There should be a new server-side action created which will be inserted into > the upgrade orchestration after core slaves has completed. This action will > be marked "COMPLETED" automatically if there are no failures detected. In the > event of 1 or more failures, this action will transition into the HOLDING > state. > > Each of the failures will be displayed in the SKIPPED_FAILED state along with > their host name, standard output and standard error. The only option > presented to the user in this state should be to ignore and proceed which > would mark the summary task as COMPLETED. > > Example Summary: > {code} > { > "href": > "http://localhost:8080/api/v1/clusters/c1/upgrades/12/upgrade_groups/4/upgrade_items/11/tasks/215";, > "Tasks": { > "attempt_cnt": 1, > "cluster_name": "c1", > "command": "EXECUTE", > "command_detail": "Verifying Skipped Failures", > "custom_command_name": > "org.apache.ambari.server.serveraction.upgrades.AutoSkipFailedSummaryAction", > "end_time": -1, > "error_log": "errors-215.txt", > "exit_code": 0, > "host_name": null, > "id": 215, > "output_log": "output-215.txt", > "request_id": 12, > "role": "AMBARI_SERVER_ACTION", > "stage_id": 11, > "start_time": 1441907533753, > "status": "HOLDING", > "stderr": "The following steps failed and were automatically > skipped:\nZOOKEEPER_CLIENT on c6403.ambari.apache.org: RESTART > ZOOKEEPER/ZOOKEEPER_CLIENT\n", > "stdout": "There were 1 skipped failure(s) that must be addressed before > you can proceed. Please resolve each failure before continuing with the > upgrade.", > "structured_out": { > "c6403.ambari.apache.org": { > "error_log": "/var/lib/ambari-agent/data/errors-214.txt", > "exit_code": 1, > "id": 214, > "output_log": "/var/lib/ambari-agent/data/output-214.txt", > "stderr": "some stderr", > "stdout": "some stdout" > } > } > } > } > {code} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > d087945 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java > 06799a0 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java > ae78890 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java > 9691292 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > cf58511 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java > a8e9c43 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java > a1e1fcd > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServerActionTask.java > 7a42c3b > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java > fdf89cc > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java > f7b37ab > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAOTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilderTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/38266/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Hurley > >
