> On Sept. 10, 2015, 3:17 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java, > > line 227 > > <https://reviews.apache.org/r/38257/diff/1/?file=1067189#file1067189line227> > > > > Technically, cluster_id = {3} needs it as well. You never know how many > > organizations run Ambari with over 1000 clusters.
MMMMmmmmmyeeaaaah :) - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38257/#review98459 ----------------------------------------------------------- On Sept. 10, 2015, 12:05 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38257/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2015, 12:05 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-13057 > https://issues.apache.org/jira/browse/AMBARI-13057 > > > Repository: ambari > > > Description > ------- > > Every invocation of MessageFormat.format() should use a number specifier: > {0,number,#} where a long is used to build queries. > > This issue can occur with any Ambari DB when the cluster has 1000+ > components. Therefore, there is a high risk of this problem occurring on a > cluster with 200+ hosts (which translates to 1000+ components, assuming 5 > components per host). > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java > 1981514 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java > c650ae7 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java > b04515a > > Diff: https://reviews.apache.org/r/38257/diff/ > > > Testing > ------- > > Manual testing of 1000+ node db. > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 58:36 min > [INFO] Finished at: 2015-09-10T12:03:18-04:00 > [INFO] Final Memory: 34M/657M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
