----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38314/#review98902 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py (line 67) <https://reviews.apache.org/r/38314/#comment155601> Ambari Configs actually have a check that compare the strings "true" "false" and convert to boolean. However, if the property doesn't exist, it should be given a default value for the sake of comprehension. E.g., default("/configurations/application-properties/atlas.enableTLS", False) - Alejandro Fernandez On Sept. 11, 2015, 8 p.m., Jonathan Maron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38314/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 8 p.m.) > > > Review request for Ambari, Erik Bergenholtz, Sumit Mohanty, and Srimanth > Gunturi. > > > Bugs: AMBARI-12410 > https://issues.apache.org/jira/browse/AMBARI-12410 > > > Repository: ambari > > > Description > ------- > > Atlas now has persisted properties for both the HTTP and HTTPS listener > ports. Rather than using the command line port option, change the service > definition to leverage these persisted properties. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/alerts.json > f324707 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml > 386fbdc > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml > 991d7fe > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py > 6c5a87e > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > a7c6d7a > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml > 2783b78 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml > 5811e4f > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > dd287b2 > ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py > cff446f > ambari-server/src/test/python/stacks/2.3/configs/default.json 688065c > ambari-web/app/models/quick_links.js b1f95d6 > > Diff: https://reviews.apache.org/r/38314/diff/ > > > Testing > ------- > > python unit tests: > > ---------------------------------------------------------------------- > Ran 230 tests in 6.879s > > OK > ---------------------------------------------------------------------- > Total run:784 > Total errors:0 > Total failures:0 > OK > > Tested property change in an installed ambari cluster. > > > Thanks, > > Jonathan Maron > >
