-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38405/
-----------------------------------------------------------

Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.


Bugs: AMBARI-13105
    https://issues.apache.org/jira/browse/AMBARI-13105


Repository: ambari


Description
-------

Desired changes:
HBase Xmn size was not adjusted
We could round off the integers to more reasonable size in MB, like 2048 vs 
1925 (Not urgent)
Warning message suggested allocating more memory to Xmx but Xmn adjustments are 
not suggested. Lets decide on maybe taking these out and rely on a ratio. (The 
original settings were recommendation from HBase team, lets adjust these based 
on our testing)
The "m" / "g" etc, for heap size parameter is inconsistent (meaning sometime 
present sometimes not), not sure if this is UI or BE problem
The suggestion that tmp dir should not be on root partition is fine but it 
should also mention, do not put it on same partition as hbase.rootdir, lets 
take out the fact that tmp.dir would be cleaned up.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
c83dd47 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
8b3bee2 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py c5abb95 

Diff: https://reviews.apache.org/r/38405/diff/


Testing
-------

OK
----------------------------------------------------------------------
Total run:778
Total errors:0
Total failures:0
OK


Thanks,

Dmytro Sen

Reply via email to