----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38415/#review99238 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/split_points.py (line 152) <https://reviews.apache.org/r/38415/#comment156170> I think, no need for -1 here >>> range(0,4) [0, 1, 2, 3] - Dmytro Sen On Сен. 16, 2015, 12:18 д.п., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38415/ > ----------------------------------------------------------- > > (Updated Сен. 16, 2015, 12:18 д.п.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Myroslav > Papirkovskyy, and Sumit Mohanty. > > > Bugs: AMBARI-13108 > https://issues.apache.org/jira/browse/AMBARI-13108 > > > Repository: ambari > > > Description > ------- > > Out of 2400 data points Kafka metrics take up 1100. In a 400 node cluster > this results in an imbalance among the load distribution on the Region Server. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/split_points.py > b8b38f9 > > Diff: https://reviews.apache.org/r/38415/diff/ > > > Testing > ------- > > Unit test pass. > > Manual test results: > > python2.6 split_points.py > '{"hbase.regionserver.global.memstore.upperLimit":"0.35", > "hbase.hregion.memstore.flush.size":"268435456"}' > '{"hbase_master_heapsize":"24576m","hbase_regionserver_heapsize":"8192m"}' > 'AMBARI_METRICS,HDFS,YARN,HBASE,KAFKA,FLUME' > > Split points for precision table : 30 > Split points for aggregate table : 7 > > > Thanks, > > Sid Wagle > >