----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38483/#review99517 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Sept. 18, 2015, 10:11 a.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38483/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2015, 10:11 a.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-13141 > https://issues.apache.org/jira/browse/AMBARI-13141 > > > Repository: ambari > > > Description > ------- > > Passwords are not masked in command output. > It seems like masking is not handled properly for the "not_if" clause. > > > > > 2015-09-11 18:42:56,872 - Execute['export > HIVE_CONF_DIR=/usr/hdp/current/hive-metastore/conf/conf.server ; > /usr/hdp/current/hive-metastore/bin/schematool -initSchema -dbType mysql > -userName hive -passWord [PROTECTED]'] {'not_if': 'ambari-sudo.sh su hive -l > -s /bin/bash -c \'export > HIVE_CONF_DIR=/usr/hdp/current/hive-metastore/conf/conf.server ; > /usr/hdp/current/hive-metastore/bin/schematool -info -dbType mysql -userName > hive -passWord \'"\'"\'PLAIN_TEXT_PASSWORD_HERE'"\'"\'\'', 'user': 'hive'} > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > 7e35a57 > > Diff: https://reviews.apache.org/r/38483/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
