----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38515/#review99803 -----------------------------------------------------------
Ship it! Ship It! - Jaimin Jetly On Sept. 19, 2015, 12:50 a.m., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38515/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2015, 12:50 a.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-13155 > https://issues.apache.org/jira/browse/AMBARI-13155 > > > Repository: ambari > > > Description > ------- > > Avoid using parentView.xxx to get data because view hierarchy keeps changing. > > > Diffs > ----- > > ambari-web/app/views/common/controls_view.js c157c67 > ambari-web/test/views/common/controls_view_test.js 6e4315c > > Diff: https://reviews.apache.org/r/38515/diff/ > > > Testing > ------- > > Manually tested on live cluster. > All unit test passed. > > 9146 tests complete (9 seconds) > 95 tests pending > > > Thanks, > > Richard Zang > >
