----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38489/#review100134 -----------------------------------------------------------
Ship it! Ship It! - Yusaku Sako On Sept. 18, 2015, 1:34 p.m., Nitiraj Rathore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38489/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2015, 1:34 p.m.) > > > Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-12321 > https://issues.apache.org/jira/browse/AMBARI-12321 > > > Repository: ambari > > > Description > ------- > > The problem was that classes in jasper-runtime were conflicting with the > jsp-2.1-glassfish. > jasper-runtime was not included in this view but was included in other views > like file and capacity-scheduler etc (via hadoop-common and hadoop-hdfs). > Although the class loaders of the views are different. But still inclusion of > jasper-runtime in other views caused error in hello-spring-view > I think this was because the Class.forName in > ./jsp-api-2.1-glassfish-2.1.v20100127.jar.src./javax/servlet/jsp/JspFactory.java:/* > 118 */ > Class factory = Class.forName("org.apache.jasper.runtime.JspFactoryImpl"); > > Also I have noted that in ambari-metrics-timelineservice excludes the > jasper-runtime. > > This patch excludes the jasper-runtime from the poms of views > > > Diffs > ----- > > contrib/views/capacity-scheduler/pom.xml 092708a > contrib/views/files/pom.xml eb144c4 > contrib/views/hive/pom.xml 455ab32 > contrib/views/pig/pom.xml f2a500a > contrib/views/utils/pom.xml f930061 > > Diff: https://reviews.apache.org/r/38489/diff/ > > > Testing > ------- > > Created builds after applying patch. so the jasper-runtime was not included > in the WEB-INF/lib of the views. > Deployed views (hive,capacity-scheduler,pig,files and hello-spring-view). All > the views were working fine. > > > Thanks, > > Nitiraj Rathore > >
