----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38763/#review100613 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/dfs_datanode_helper.py (line 28) <https://reviews.apache.org/r/38763/#comment157833> Thanks for storing this in a HEADER ambari-common/src/main/python/resource_management/libraries/functions/dfs_datanode_helper.py <https://reviews.apache.org/r/38763/#comment157837> Couldn't we just have called, File(params.data_dir_mount_file, owner=params.hdfs_user, group=params.user_group, mode=0644, content="..." ) ? ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py (line 50) <https://reviews.apache.org/r/38763/#comment157832> To make this more readable, can we split it up? data_dir_to_mount = handle_dfs_data_dir(create_dirs, params) File(params.data_dir_mount_file, owner=params.hdfs_user, group=params.user_group, mode=0644, content=data_dir_to_mount ) - Alejandro Fernandez On Sept. 25, 2015, 2:27 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38763/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 2:27 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Dmitro > Lisnichenko. > > > Bugs: AMBARI-13241 > https://issues.apache.org/jira/browse/AMBARI-13241 > > > Repository: ambari > > > Description > ------- > > Install HDP 2.2.6 > Perform Ru to HDP2.3.2.0 > Noticed alert for datanode > File not found, /etc/hadoop/conf/dfs_data_dir_mount.hist . Data dir(s) are > fine, /grid/0/hadoop/hdfs/data . > This file seems to be lost post RU > ls /etc/hadoop/conf/dfs_data_dir_mount.hist > ls: cannot access /etc/hadoop/conf/dfs_data_dir_mount.hist: No such file or > directory > > > Diffs > ----- > > ambari-agent/src/test/python/resource_management/TestDatanodeHelper.py > a74cc0b > > ambari-common/src/main/python/resource_management/libraries/functions/dfs_datanode_helper.py > 778d869 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py > df847bd > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8e6e386 > > Diff: https://reviews.apache.org/r/38763/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 244 tests in 8.791s > > OK > ---------------------------------------------------------------------- > Total run:801 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Dmytro Sen > >
