-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38824/#review100920
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Sept. 29, 2015, 1:47 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38824/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 1:47 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
> 
> 
> Bugs: AMBARI-13263
>     https://issues.apache.org/jira/browse/AMBARI-13263
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a Ranger theme with Ranger Admin.
> This also includes task for making theme driven conditional config attributes 
> changes.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
>  e8cd074 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigCondition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigPlacement.java
>  c20cd8e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/Subsection.java
>  b86b51f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/Widget.java 
> 7b1e09c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml
>  936c332 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml
>  95c3b50 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml
>  114c3ab 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml
>  8308865 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 
> a13fabf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme.json
>  PRE-CREATION 
>   ambari-web/app/app.js 63edd46 
>   ambari-web/app/controllers/main/service/info/configs.js 937d093 
>   ambari-web/app/controllers/wizard/step7_controller.js 1b25156 
>   ambari-web/app/data/HDP2.2/site_properties.js feda591 
>   ambari-web/app/data/HDP2.3/site_properties.js adf8cae 
>   ambari-web/app/mappers/configs/themes_mapper.js e632860 
>   ambari-web/app/models.js 6bffb95 
>   ambari-web/app/models/configs/config_condition.js PRE-CREATION 
>   ambari-web/app/models/configs/section.js 8f45757 
>   ambari-web/app/models/configs/stack_config_property.js 1289662 
>   ambari-web/app/models/configs/sub_section.js d33fbb9 
>   ambari-web/app/templates/common/configs/service_config_layout_tab.hbs 
> ac1dcc7 
>   
> ambari-web/app/templates/common/configs/widgets/test_db_connection_widget.hbs 
> PRE-CREATION 
>   ambari-web/app/utils/config.js 1e9b262 
>   ambari-web/app/views.js 8ccb9a2 
>   ambari-web/app/views/common/configs/service_config_layout_tab_view.js 
> b3d69ee 
>   ambari-web/app/views/common/configs/widgets/config_widget_view.js 354a44e 
>   ambari-web/app/views/common/configs/widgets/password_config_widget_view.js 
> d33cd13 
>   
> ambari-web/app/views/common/configs/widgets/test_db_connection_widget_view.js 
> PRE-CREATION 
>   ambari-web/test/mappers/configs/themes_mapper_test.js 63b937c 
>   ambari-web/test/models/configs/section_test.js c8f2ebf 
> 
> Diff: https://reviews.apache.org/r/38824/diff/
> 
> 
> Testing
> -------
> 
> Verified manually on a cluster.
> Verified that all ambari-web unit tests passes successfully:
> 
> 
>   9386 tests complete (11 seconds)
>   94 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Reply via email to